Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 9 (bis) #91

Merged
merged 1 commit into from
Apr 14, 2020
Merged

Angular 9 (bis) #91

merged 1 commit into from
Apr 14, 2020

Conversation

PowerKiKi
Copy link
Contributor

This is a rebase of #85 with minor additional fixes

@PowerKiKi PowerKiKi mentioned this pull request Apr 13, 2020
@odahcam
Copy link
Collaborator

odahcam commented Apr 13, 2020

Nice PR, can you confirm that you can build the lib for production?

@PowerKiKi
Copy link
Contributor Author

I confirm that I can build the lib for production.

I am not quite sure why we don't see Travis status in this issue, but you can see it is successful over there: https://travis-ci.org/github/HaithemMosbahi/ngx-avatar/builds/674264612

Also locally the following command will also succeed (although with warnings, but I don't know if they are new or not):

ng build ngx-avatar && ng build ngx-avatar-demo

@odahcam
Copy link
Collaborator

odahcam commented Apr 14, 2020

I am not quite sure why we don't see Travis status in this issue

Probably because it is not configured as a request for PRs and because it's travis .org not .com, so it won't work with Checks, just plain old hooks.

I confirm that I can build the lib for production.

I wasn't able to build it in my Windows computer, but Travis is enough for me.

@odahcam odahcam merged commit f1cb442 into HaithemMosbahi:master Apr 14, 2020
@PowerKiKi
Copy link
Contributor Author

Thank you for merging.

Will you be able to release this yourself ?

According to what I see on https://www.npmjs.com/package/ngx-avatar, @HaithemMosbahi is the only collaborator for this package. It would be best to at least have a second collaborator and/or setup an auto-publish mechanism from Travis to npm.

Here is an example on how to automatically publish tags as release which should be easy to adapt for this lib. But I cannot create a PR for it since I don't know the credentials to be encoded: https://github.com/Ecodev/fab-speed-dial/blob/123e63c7faeef1d469618dcefb4a111d82fc817f/.travis.yml#L32-L47

@PowerKiKi PowerKiKi deleted the angular-9 branch April 15, 2020 02:03
@odahcam
Copy link
Collaborator

odahcam commented Apr 15, 2020

I agree with you and, unfortunately for who is in a hurry, only Haithem is able to do this for us now. Once he's back I'm pretty sure configuring a auto-publish workflow would be awesome, you could open a issue discussing that if you want, I like the idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants